Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Dialog): accessibility aria attributes #4838

Merged
merged 16 commits into from Aug 26, 2021
Merged

[core] feat(Dialog): accessibility aria attributes #4838

merged 16 commits into from Aug 26, 2021

Conversation

evansjohnson
Copy link
Contributor

Fixes #4528

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

add aria-labelledby and aria-describedby props to Dialog with aria-labelledby defaulting to title element

Screenshot

Screen Shot 2021-08-05 at 8 58 24 AM

Screen Shot 2021-08-05 at 8 58 49 AM

adidahiya
adidahiya suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update dialogExample.tsx as well... I think we just need to add an aria-describedby prop and point it to an ID we add to the Classes.DIALOG_BODY element

packages/core/src/components/dialog/dialog.tsx Outdated Show resolved Hide resolved
packages/core/test/dialog/dialogTests.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dialog/dialog.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dialog/dialog.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title Dialog a11y roles [core] feat(Dialog): a11y aria attributes Aug 11, 2021
@evansjohnson evansjohnson changed the title [core] feat(Dialog): a11y aria attributes [core] feat(Dialog): accessibility aria attributes Aug 12, 2021
@adidahiya
Copy link
Contributor

sorry about the test flakes in the table package test suite... I will look into that soon

adidahiya
adidahiya suggested changes Aug 17, 2021
View reviewed changes
packages/core/src/common/utils/jsUtils.ts Outdated Show resolved Hide resolved
packages/core/test/dialog/dialogTests.tsx Outdated Show resolved Hide resolved
packages/core/test/dialog/dialogTests.tsx Outdated Show resolved Hide resolved
packages/core/test/dialog/dialogTests.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya merged commit 6c76688 into palantir:develop Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialogs should have proper a11y markup
3 participants
@evansjohnson @adidahiya @jabsatz