Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Button): use 12px font in small buttons #4885

Merged
merged 1 commit into from Aug 30, 2021

Conversation

adidahiya
Copy link
Contributor

Fixes #3448

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Update small buttons to use 12px font
    • The mixin I changed is only used in button and tag input styles, and it doesn't have any effect on the latter, so it's ok to change the mixin. The font-size declaration matches the same place it's defined for large buttons.
  • Add a radio-style button group size selector to the button example in the docs

Reviewers should focus on:

N/A

Screenshot

2021-08-30 18 27 01

@blueprint-bot
Copy link

[core] fix(Button): use 12px font in small buttons

Previews: documentation | landing | table

@adidahiya adidahiya merged commit 4429ae8 into develop Aug 30, 2021
@adidahiya adidahiya deleted the ad/small-button-font-size branch August 30, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small button design difference in Sketch/Figma and CSS
2 participants