Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] [core] chore: fix isolatedModules compilation error #5015

Merged
merged 2 commits into from
Nov 8, 2021
Merged

[v4] [core] chore: fix isolatedModules compilation error #5015

merged 2 commits into from
Nov 8, 2021

Commits on Nov 7, 2021

  1. Fix isolatedModules error with "Icon" component 

    Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.  TS1205

    22 | import { AbstractPureComponent2, Classes, DISPLAYNAME_PREFIX, IntentProps, Props, MaybeElement } from "../../common";
    23 | 
  > 24 | export { IconName };
       |          ^
    25 | 
    26 | export enum IconSize {
    27 |     STANDARD = 16,
    @LevanKvirkvelia
    LevanKvirkvelia committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    7089c00 View commit details
    Browse the repository at this point in the history

  2. Update icon.tsx

    @LevanKvirkvelia
    LevanKvirkvelia committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    f592f49 View commit details
    Browse the repository at this point in the history