Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] [core] Update button borders and background gradient #5046

Merged
merged 2 commits into from Nov 30, 2021
Merged

[v4] [core] Update button borders and background gradient #5046

merged 2 commits into from Nov 30, 2021

Conversation

johnly13
Copy link
Contributor

@johnly13 johnly13 commented Nov 30, 2021 •
edited

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Update button borders to be consistently inset across light mode and dark mode
  • Update button background gradients

Reviewers should focus on:

Screenshot

Light mode
Static Hover Active
Before
1 before static light 2 before hover light 3 before active light
After
1 after static light 2 after hover light 3 after active light
Dark mode
Static Hover Active
Before
4 before static dark 5 before hover dark 6 before active dark
After
4 after static dark 5 after hover dark 6 after active dark

@blueprint-bot
Copy link

fix lint

Previews: documentation | landing | table | modern colors demo

adidahiya
adidahiya approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adidahiya adidahiya merged commit 54cb93f into next Nov 30, 2021
@adidahiya adidahiya deleted the jl/v4-button-revisions branch November 30, 2021 22:08
@adidahiya
Copy link
Contributor

I just noticed that this changed the size of switch controls in dark theme:

Before:

image

After:

image

Was this intentional?

@johnly13 johnly13 mentioned this pull request Dec 3, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnly13 @blueprint-bot @adidahiya