[v4] [table] fix: prevent scrolling to ghost rows #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[table] WIP fix ghost cells bugPreviews: documentation | landing | table | modern colors demo |
This reverts commit 3e9711f.
adidahiya
changed the title
[table] fix ghost cells scrollingPreviews: documentation | landing | table | modern colors demo |
Fix linting, formattingPreviews: documentation | landing | table | modern colors demo |
|
if you scroll too fast, you get blank sections of the table on the bottom / right where the viewport does not update:
|
WIP another strategyPreviews: documentation | landing | table | modern colors demo |
Remove dead codePreviews: documentation | landing | table | modern colors demo |
adidahiya
commented
Feb 10, 2022
| }); | ||
|
|
||
| function runTestToEnsureScrollingIsEnabled(enableGhostCells: boolean) { | ||
| it(`isn't disabled when there is half a row left to scroll to and enableGhostCells is set to ${enableGhostCells}`, () => { |
There was a problem hiding this comment.
note that these two tests were ported over from 7460d10
fix lint, formattingPreviews: documentation | landing | table | modern colors demo |
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5027
Checklist
Changes proposed in this pull request:
Add Table2 vertical scroll logic to detect when scrolling has reached the bottom of the rendered cells, so it's not necessary to allow scrolling further down to the ghost cells.Edit: that approach was quite buggy, so I figured out a better one. We don't need to render ghost rows or columns at all, when there is vertical or horizontal overflow, respectively.
Reviewers should focus on:
This should fix the linked bug.
Screenshot
with ghost cells enabled in the table dev app: