[node-build-scripts] fix(generate-css-variables): LibSass compat #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoldberg
force-pushed
the
pgoldberg/fixScssVariableOutput
branch
from
eb75a1f
to
575f902
Compare
adidahiya
previously approved these changes
Apr 7, 2022
| } | ||
| variablesScss = [COPYRIGHT_HEADER, USE_MATH_RULE, variablesScss].join("\n"); | ||
| cleanedInput = [USE_MATH_RULE, cleanedInput].join("\n"); |
There was a problem hiding this comment.
no need for the USE_MATH_RULE now, we can remove that constant completely
There was a problem hiding this comment.
It is actually needed here so it can properly run through getSassVars (which compiles with sass, so without it, it wouldn't know how to resolve math.divs). When it goes through generateScssVariables there's no outputted @use "sass:math"
There was a problem hiding this comment.
oh wait, I guess we need this to compute the values... sorry, disregard
adidahiya
approved these changes
Apr 7, 2022
adidahiya
changed the title
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5244
Uses
get-sass-varsfor scss variable generation as well as less generationChecklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot