Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable today button if today's date cannot be chosen #5247

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

scooobs
Copy link
Contributor

@scooobs scooobs commented Apr 8, 2022

Fixes #5227

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Disable the Today button in the Actions bar if it does not fall between minDate and maxDate.

Screenshot

(here minDate is April 8th 2023 and maxDate is April 8th 2025)
Screen Shot 2022-04-08 at 3 26 23 pm

With regards to documentation, is there anything that needs to be updated?

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise 👍

packages/datetime/src/common/classes.ts Outdated Show resolved Hide resolved
@adidahiya adidahiya merged commit 749da9b into palantir:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "minDate" and "maxDate" to "Today" button on datepicker action bar
2 participants