Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime] fix(DatePicker): disable clear button #5249

Merged
merged 1 commit into from
Apr 15, 2022
Merged

[datetime] fix(DatePicker): disable clear button #5249

merged 1 commit into from
Apr 15, 2022

Conversation

scooobs
Copy link
Contributor

@scooobs scooobs commented Apr 9, 2022

Fixes #5228

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

When canClearSelection is false, disable the Clear button on the Actions Bar of the Date Picker.

Screenshot

Screen Shot 2022-04-09 at 5 24 00 pm

Screen Shot 2022-04-09 at 5 24 27 pm

adidahiya
adidahiya approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@adidahiya adidahiya changed the title Disable Clear button in Actions Bar when canClearSelection is disabled [datetime] fix(DatePicker): disable clear button Apr 15, 2022
@adidahiya adidahiya merged commit 8a5a28b into palantir:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow "clear" button on datepicker action bar when "canClearSelection" is set
2 participants
@scooobs @adidahiya