Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint config, migrate some rules away from TSLint #5272

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

  • Enable ESLint sort-imports rule, apply auto fixer to re-sort import statements
  • Enable ESLint @typescript-eslint/no-extraneous-class rule
  • Migrate TSLint variable-name -> ESLint @typescript-eslint/naming-convention rule
  • Disable TSLint only-arrow-functions rule (already covered by ESLint prefer-arrow-callback)

This leaves just no-submodule-imports and object-literal-sort-keys enabled in the TSLint config. There are no equivalent lint rules out there that do exactly what we want here, so we'll have to implement some new rules ourselves if we want to fully migrate away from TSLint.

See typescript-eslint/ROADMAP.

@blueprint-bot
Copy link

lint fix

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 71240e0 into develop Apr 26, 2022
@adidahiya adidahiya deleted the ad/eslint-config branch April 26, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants