Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] feat: new prop "enableColumnHeader" #5283

Merged
merged 8 commits into from
May 4, 2022

Conversation

jmcglinch
Copy link
Contributor

@jmcglinch jmcglinch commented May 3, 2022

Fixes #5200

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds enableColumnHeader prop to table and table2 components. The column header is not rendered if false.

Reviewers should focus on:

Focus on render logic relating to the column header. Also, check SYNC_TRIGGER_PROP_KEYS configuration.

Screenshot

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @jmcglinch! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@jmcglinch jmcglinch changed the title Jm/enable column header [table] adds enable column header prop; Fixes #5200 May 3, 2022
@jmcglinch jmcglinch changed the title [table] adds enable column header prop; Fixes #5200 [table] adds enable column header prop May 4, 2022
@adidahiya adidahiya changed the title [table] adds enable column header prop [table] feat: new prop "enableColumnHeader" May 4, 2022
@adidahiya adidahiya self-assigned this May 4, 2022
@adidahiya
Copy link
Contributor

hey @jmcglinch, thanks for the PR! This gets us most of the way there, but there's a bug in rendering because of assumptions about the minimum column header height. there are references to Grid.MIN_COLUMN_HEADER_HEIGHT which need to be adjusted. I am working on a fix which I will push to this branch.

image

@adidahiya
Copy link
Contributor

preview build: docs-app, table-dev-app

@adidahiya adidahiya merged commit a7b53cb into palantir:develop May 4, 2022
@jmcglinch jmcglinch deleted the jm/enable-column-header branch May 4, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow column headers to be hidden in Table component
3 participants