Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(NonIdealState): minor layout/visual bugs #5299

Merged
merged 2 commits into from
May 12, 2022
Merged

[core] fix(NonIdealState): minor layout/visual bugs #5299

merged 2 commits into from
May 12, 2022

Conversation

adidahiya
Copy link
Contributor

Fixes #5292, fixes #5293

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Fix NonIdealState markup to omit empty element when both title and description props are undefined
  • Fix NonIdealState icon/visual styling to only target BP icon SVGs, not Spinner SVGs
  • Fix NonIdealState icon/visual line height to make the height adjust for smaller sizes
  • Add options to NonIdealState example in docs-app to demo the Spinner

Reviewers should focus on:

Fixes the linked issues

Screenshot

image

image

@blueprint-bot
Copy link

[core] fix(NonIdealState): minor layout/visual bugs

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

update CSS API markup & docs

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 6062fdc into develop May 12, 2022
@adidahiya adidahiya deleted the ad/fix-non-ideal-state branch May 12, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adidahiya @blueprint-bot