Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-build-scripts] fix(css-variables): string quotes for all values #5304

Merged
merged 1 commit into from
May 16, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

#5303 fixed generate-css-variables to preserve string quotes for values inside lists, but after merging that I realized it doesn't actually target the broken use case I needed it to, which is a simple Sass variable value of a single string, like this:

// src/common/_variables.scss
$resources-path: "../../resources" !default;

Turns out we can simplify the change made in #5303 and apply it to all values which are not (List, Map, Color, or Number) in the JSON encoder.

So now we expect the above variable to be preserved exactly as-is in the output:

// lib/scss/variables.scss
$resources-path: "../../resources" !default;

Reviewers should focus on:

No regressions w/r/t #5303

@adidahiya adidahiya merged commit 3631905 into develop May 16, 2022
@adidahiya adidahiya deleted the ad/css-variables-quotes-no-list branch May 16, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants