Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Toast): add alert role to toast message for a11y #5325

Merged
merged 2 commits into from
May 26, 2022
Merged

[core] fix(Toast): add alert role to toast message for a11y #5325

merged 2 commits into from
May 26, 2022

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented May 25, 2022 •
edited

Fixes #5324

Checklist

  • [N/A] Includes tests
  • [N/A] Update documentation

add role="alert" to toast message for a11y purposes.

@bvandercar-vt
Copy link
Contributor Author

issue #5324

@bvandercar-vt bvandercar-vt changed the title fix(a11y): add alert role to toast message fix(a11y): add alert role to toast message (#5324) May 25, 2022
@adidahiya
Copy link
Contributor

I think this should only be applied to the toast message, according to the docs:

The alert role should only be used for text content, not interactive elements such as links or buttons.

@bvandercar-vt
Copy link
Contributor Author

I think this should only be applied to the toast message, according to the docs:

The alert role should only be used for text content, not interactive elements such as links or buttons.

updated. or would you prefer to kill this PR and have the user pass say, <span role="alert">Users Message</span> as the message themselves?

adidahiya
adidahiya approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adidahiya adidahiya changed the title fix(a11y): add alert role to toast message (#5324) [core] fix(Toast): add alert role to toast message for a11y (#5324) May 26, 2022
@adidahiya adidahiya changed the title [core] fix(Toast): add alert role to toast message for a11y (#5324) [core] fix(Toast): add alert role to toast message for a11y May 26, 2022
@adidahiya adidahiya merged commit f03f8f6 into palantir:develop May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add role="alert" to toast messages for better a11y
2 participants
@bvandercar-vt @adidahiya