[eslint-plugin] feat: no-deprecated-components rule #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more testsPreviews: documentation | landing | table | demo |
adidahiya
suggested changes
Jun 3, 2022
|
|
||
| export class MyClass extends BP.AbstractComponent { | ||
| } | ||
| class MyClass2 extends BP.AbstractComponent {} |
There was a problem hiding this comment.
looks like two errors should be expected here instead of just one
There was a problem hiding this comment.
hm.. it passes both if i pass 1 error or 2 errors below 🤔
add more components, PR commentsPreviews: documentation | landing | table | demo |
adidahiya
suggested changes
Jun 6, 2022
update docsPreviews: documentation | landing | table | demo |
adidahiya
approved these changes
Jun 6, 2022
|
thanks @styu! |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Adds an ESLint rule that flags particular deprecated blueprint components and recommends their v2 versions instead
Reviewers should focus on:
What other components am I missing?
Screenshot