[core] fix(Overlay): escape key closing behavior #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
force-pushed
the
overlay-fixes
branch
2 times, most recently
from
83778a0
to
a82763a
Compare
This replaces use of the deprecated keyboard event `which` property with the proper `key` property. Issue: palantir#4165
This adds a call to e.stopPropagation() to prevent nested overlays from closing on a single key press. Fixes: palantir#5099
adidahiya
approved these changes
Jul 8, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5099, fixes #4300
Checklist
Changes proposed in this pull request:
This is a couple of small fixes related to pressing the escape key on overlays.
Reviewers should focus on:
Screenshot