[select] feat(MultiSelect2): 'onClear' prop renders clear button #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Before this change, we rendered a "clear" button in the MultiSelect2 example in the docs with a custom element supplied through
tagInputProps={ rightElement: ... }.This functionality should be provided out of the box, as it's a common use case. So I've added that here in this PR.
The clear button is enabled when an
onClearcallback prop is defined, and omitted when that prop is undefined. It doesn't make much sense to render a button when it's not hooked up to do anything.Reviewers should focus on:
No regression from existing behavior in docs