Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-app] feat(DateInput2Example): use date-fns formatter #5371

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jun 14, 2022

  • [datetime2] fix: loosen date-fns version dependency range, upgrade to latest to fix some bugs
  • [docs-app] feat(DateInput2Example): use date-fns to format & parse dates instead of moment.js
    • one of the benefits of datetime2 is supposed to be that we're dropping moment.js... so we need to do this in the documentation as well.

@blueprint-bot
Copy link

[docs-app] feat: use date-fns format selector for DateInput2

Previews: documentation | landing | table | demo

@adidahiya adidahiya changed the title [docs-app] feat(DateInput2Example): use new date-fns format selector [docs-app] feat(DateInput2Example): use date-fns formatter Jun 14, 2022
@blueprint-bot
Copy link

Fix lint

Previews: documentation | landing | table | demo

@adidahiya
Copy link
Contributor Author

@vhellem for SA

@adidahiya adidahiya merged commit 3f351c2 into develop Jun 15, 2022
@adidahiya adidahiya deleted the ad/date-fns-format-select-rebased branch June 15, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants