Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix(QueryList): pass menuProps to itemListRenderer #5376

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

So basically, on a previous PR I submitted, we did not consider the case where a user passes a custom itemListRenderer, as they do in the Select2 example-- in this case, a user needs access to the menuProps to get the generated listboxId so that they can assign id={listboxId} to their custom Menu item in their itemListRenderer-- currently, the id={listboxId} only gets applied to the default itemListRenderer.

If this solution isn't approved, the alternative workaround to this would be for a user to create their own id, set Menu id=${id} in their custom itemListRenderer, then pass popoverTargetProps={{aria-controls={id}. If this isn't approved, I would like to add that example to the Select2 example implementation

@adidahiya adidahiya changed the title allow for access to menu id when providing custom itemListRenderer [select] fix(QueryList): pass menuProps to custom itemListRenderer for id Jun 15, 2022
@adidahiya adidahiya changed the title [select] fix(QueryList): pass menuProps to custom itemListRenderer for id [select] fix(QueryList): pass menuProps to custom itemListRenderer Jun 15, 2022
@adidahiya adidahiya changed the title [select] fix(QueryList): pass menuProps to custom itemListRenderer [select] fix(QueryList): pass menuProps to itemListRenderer Jun 15, 2022
@adidahiya adidahiya merged commit f9df52a into palantir:develop Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants