[core] fix(Menu): remove extraneous submenu icon title #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
changed the title
bvandercar-vt
changed the title
bvandercar-vt
changed the title
adidahiya
approved these changes
Jul 7, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Remove icon title because not necessary/ doesn't provide any good info for the icon.
Reason 1) Expanding the sub-menu is not only performed by hovering over the icon, but can be performed by hovering over the whole button-- so, having "Open sub menu" on the icon is misleading because it can be opened by hovering over any part of the button, not just the icon.
Reason 2) The icon pretty much already has its own label given by the fact that it is part of the button, which contains text that describes the sub-menu-- having this additional title adds no value.