Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] feat(DateInput2): remove target wrapper, fix fill prop #5473

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 1, 2022

Fixes #5472

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Refactor DateInput2 to use Popover2's renderTarget API, like we do in Select2, Suggest2, and MultiSelect2. Note that this is a breaking change to the DOM layout, as we have combined the popover target and input group elements into one:
- <span aria-haspopup="true" class="bp4-date-input bp4-popover2-target">
-   <div class="bp4-input-group">
-     <input>
- </span>
+ <div class="bp4-input-group bp4-date-input bp4-popover2-target">
+   <input aria-haspopup="true">
+ </div>
  • Fix fill prop so it now works as expected

Reviewers should focus on:

N/A

Screenshot

image

@adidahiya adidahiya changed the title [datetime2] feat(DateInput2): remove target wrapper el, fix fill prop [datetime2] feat(DateInput2): remove target wrapper, fix fill prop Aug 1, 2022
@blueprint-bot
Copy link

fix scss typo

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

fix renderTarget deps, fix tests

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Fixup comments, remove isOpen dep

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit cec40f7 into develop Aug 1, 2022
@adidahiya adidahiya deleted the ad/fix-dateinput2-fill branch August 1, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateInput2 fill prop not working
2 participants