Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Tag): remove aria-labelledby attribute #5475

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Changes proposed in this pull request:

aria-labelledby should only apply when a role is passed-- should not be on the Tag because the Tag is just a span and has no role prop

@adidahiya
Copy link
Contributor

aria-labelledby should only apply when a role is passed

documentation link for this?

@bvandercar-vt
Copy link
Contributor Author

aria-labelledby should only apply when a role is passed

documentation link for this?

we are now failing the aXe aria-allowed-attr rule because we are applying an aria-labelledby prop to a span element. https://accessibilityinsights.io/info-examples/web/aria-allowed-attr/

If this span were to have a different role assigned, this would be allowed, but as of now, the Tag span is just a span.

@adidahiya adidahiya changed the title fix aria-labelledby prop [core] fix(Tag): remove aria-labelledby attribute Aug 2, 2022
@adidahiya adidahiya merged commit c6b8845 into palantir:develop Aug 2, 2022
@adidahiya
Copy link
Contributor

I couldn't find any role which is suitable for all/any Tags in general, so I guess it's better to remove this attribute if we can't set role ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants