Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] feat(no-deprecated-components): more components #5477

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

  • Add @blueprintjs/datetime package to the list of packages which the rule checks for deprecated imports
  • Add components to list of deprecations / disallowed imports:
    • DateInput
    • DateTimePicker
    • MenuItem

Reviewers should focus on:

Difficulty of rolling this out, as it's kind of a breaking change for the lint rule (builds with the rule set to "error" will start failing).

@blueprint-bot
Copy link

Merge remote-tracking branch 'origin/develop' into ad/no-deprecated-components-enhancements

Previews: documentation | landing | table | demo

@adidahiya
Copy link
Contributor Author

Difficulty of rolling this out, as it's kind of a breaking change for the lint rule (builds with the rule set to "error" will start failing).

The plan here is to introduce rule configuration which allows users to opt-out of strict "error" violations for specific Blueprint packages (downgrading them to "warn" violations). This could allow, for example, someone to migrate away from deprecated @blueprintjs/core components while continuing to use deprecated @blueprintjs/datetime components during an incremental migration effort.

@adidahiya adidahiya changed the title [eslint-plugin] feat(no-deprecated-components): add more components [eslint-plugin] feat(no-deprecated-components): more components Aug 3, 2022
@adidahiya adidahiya merged commit 9c94d88 into develop Aug 3, 2022
@adidahiya adidahiya deleted the ad/no-deprecated-components-enhancements branch August 3, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants