[core] fix: partially revert #5493, create Portal2 #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] fix: partially revert #5493, create Portal2Previews: documentation | landing | table | demo |
minor docs fixPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
#5493 caused some unintentional subtle breaks in interactions between the newly refactored Portal function component and the (long-deprecated) react-hot-loader library. To be extra safe, we're going to punt this component refactor to Blueprint v5.0.
This PR reverts Portal to be a class component. I haven't fully reverted #5493 because I wanted to keep the changes which removed React 15 support (which we stopped supporting a long time ago).
The new Portal function component implementation from #5493 is being kept in the repo as Portal2. For now, it is unused. #5511 tracks promoting Portal2 -> Portal in Blueprint v5.0 (along with the new tests and PortalProvider functionality).