fix(no-deprecated-type-references): no overlapping import fixes #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlapping import fixes
Remove unused importPreviews: documentation | landing | table | demo |
styu
reviewed
Sep 7, 2022
Add test casePreviews: documentation | landing | table | demo |
styu
approved these changes
Sep 7, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Fix the
@blueprintjs/no-deprecated-type-referencesrule to return fixes properly so that multiple instances/uses of a deprecated type are all fixed, and not just the first one.Reviewers should focus on:
Check out the new test case. That was failing before this change, as only the first type reference of
IItemRendererPropswas getting replaced withItemRendererProps.The problem was that we were reporting a fix on the type reference and the import of that type for every instance of deprecated usage (two fixes for a single violation). ESLint will not apply overlapping fixes, so only the first fix list was being applied, even though all violations were being reported.