Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(MultistepDialog): tooltips on navigation buttons #5534

Merged
merged 10 commits into from
Sep 14, 2022

Conversation

ohcnivek
Copy link
Contributor

@ohcnivek ohcnivek commented Sep 10, 2022

Fixes #5519

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • adding an extra prop, tooltipContent, to abstractButton.tsx props, which by association enables the prop to exist on DialogStepButtonProps
  • renders tooltip on dialog step button if tooltipContent prop exists (user should define when it exists / doesnt, checkout the example. packages/docs-app/src/examples/core-examples/multistepDialogExample.tsx)
  • also adjusted the example in docs to reflect changes

Reviewers should focus on:

Screenshot

Screen.Recording.2022-09-10.at.1.47.00.AM.mov

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @ohcnivek! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ohcnivek ohcnivek marked this pull request as ready for review September 10, 2022 05:57
@ohcnivek ohcnivek changed the title [core] adding tooltip to MultistepDialog back, next, final button [core] feat: adding tooltip to MultistepDialog back, next, final button Sep 10, 2022
@adidahiya adidahiya changed the title [core] feat: adding tooltip to MultistepDialog back, next, final button [core] feat(MultistepDialog): support tooltip content on navigation buttons Sep 12, 2022
@adidahiya adidahiya changed the title [core] feat(MultistepDialog): support tooltip content on navigation buttons [core] feat(MultistepDialog): support tooltips on navigation buttons Sep 12, 2022
@adidahiya
Copy link
Contributor

There's another issue here -- Tooltips don't play nicely with disabled Buttons. This edge case will be common with the tooltipContent, as users will likely be showing something in the tooltip when the button is disabled. See the Button docs for more info. It's better to use an AnchorButton.

2022-09-13 17 08 51

I'll push a commit here to make these fixes.

@adidahiya
Copy link
Contributor

docs preview build looks good 👍🏽

@adidahiya adidahiya changed the title [core] feat(MultistepDialog): support tooltips on navigation buttons [core] feat(MultistepDialog): tooltips on navigation buttons Sep 14, 2022
@adidahiya adidahiya merged commit 4d6240f into palantir:develop Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip to MultistepDialog final button
3 participants