Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Toast): new prop isCloseButtonShown #5535

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[core] feat(Toast): new prop isCloseButtonShown #5535

merged 1 commit into from
Sep 12, 2022

Conversation

ohcnivek
Copy link
Contributor

Fixes #5508

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • added new prop, isCloseButtonShown, following name conventions in <Dialog>
  • conditionally renders the close button on a toast with this new prop
  • added new example that uses the new prop

Reviewers should focus on:

  • maybe a better example? tried to use the use case provided in the issue, lmk if you have any better ideas!

Testing / Screenrecording

Screen.Recording.2022-09-10.at.3.56.48.AM.mov

@ohcnivek ohcnivek marked this pull request as ready for review September 10, 2022 08:10
adidahiya
adidahiya approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, simple and clean PR. thanks @ohcnivek!

@adidahiya
Copy link
Contributor

docs preview build with new Toast example

@adidahiya adidahiya changed the title [core] feat: adding ability to optionally display close button for toasts [core] feat(Toast): new prop isCloseButtonShown Sep 12, 2022
@adidahiya adidahiya merged commit 1d1ee14 into palantir:develop Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast should have an option to not show close button
2 participants
@ohcnivek @adidahiya