fix(DateRangePicker): various layout issues, footerElement prop #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fix lintPreviews: documentation | landing | table | demo |
adidahiya
commented
Sep 13, 2022
| .#{$ns}-daterangepicker { | ||
| display: flex; | ||
| white-space: nowrap; |
There was a problem hiding this comment.
This style has been around since the beginning of this OSS repo, and it's not clear exactly what the benefit is. It's a strange style to inherit for anyone specifying a custom footerElement, so I've chosen to remove it in this PR. I'll keep an eye out for unintended breaks caused by this.
|
|
||
| .DayPicker-NavButton--interactionDisabled { | ||
| display: none; | ||
| } | ||
|
|
||
| .#{$ns}-daterangepicker-timepickers { |
There was a problem hiding this comment.
Moved this block below to reduce CSS specificity
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5537
Checklist
Changes proposed in this pull request:
Fix DateRangePicker (and transitively, DateRangeInput & DateRangeInput2) to render
footerElementcorrectlyFix a bug in DateRangePicker where it would render both time pickers with
showSingleMonthOnly={true}and time pickers enabledReviewers should focus on:
Making a custom
footerElementwork in the popover layout required adjusting the DOM structure of DRP somewhat to ensure that the calendars and time pickers get aligned correctly even when there is a very wide footer element that expands the width of the popover and creates extra whitespace. There are some new flexbox container elements. See the screenshot below.Screenshot