Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime2] fix: remove errant whitespace in timezones list #5637

Merged
merged 1 commit into from
Oct 3, 2022
Merged

[datetime2] fix: remove errant whitespace in timezones list #5637

merged 1 commit into from
Oct 3, 2022

Conversation

zenyr
Copy link
Contributor

@zenyr zenyr commented Oct 3, 2022 •
edited

Checklist

  • Includes tests
  • Update documentation
  • I am sorry

Changes proposed in this pull request:

  • Fixed a SUPER TINY typo in the dataset that MIGHT cause a bug, (tbh negligible but better be fixed!)

Reviewers should focus on:

  • How petty I am to submit a single line PR (:smile:)
  • Seriously, I feel guilty about this PR but hey I found something!
  • Also one of my colleague and lots of lived in Vancouver and a lot of my friends still do so I've got that going for me, which is nice
  • Aaand I had been in love with elegant design of blurprint.js since years ago and I still do.

Screenshot

  • None, since white-spaces are generally invisible inside ReactNode.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @zenyr! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@zenyr zenyr changed the title chore: Fix a tiny stray space from the dataset chore: Fix a tiny stray space from the Timezone dataset Oct 3, 2022
adidahiya
adidahiya approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every little bit helps, thanks for the contribution @zenyr :)

@adidahiya adidahiya changed the title chore: Fix a tiny stray space from the Timezone dataset [datetime2] fix: remove errant whitespace in timezones list Oct 3, 2022
@adidahiya adidahiya merged commit 847bbec into palantir:develop Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenyr @palantirtech @adidahiya