Smoothen Omnibar fadeout #5681
Merged
Smoothen Omnibar fadeout #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smoothen Omnibar fadeoutPreviews: documentation | landing | table | demo |
henrywarhurst
force-pushed
the
hwarhurst/omnibar-smoother-fade-out
branch
from
b6e296c
to
6caa2df
Compare
Smoothen Omnibar fadeoutPreviews: documentation | landing | table | demo |
adidahiya
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5419
Checklist
Changes proposed in this pull request:
It has always bothered me the way the Omnibar hiccups when it fades out before disappearing from screen. I always thought it was some slow reflow issue, but it's actually just because we don't fade down to 0 opacity. I've changed that behaviour here and think it looks and feels better.
Reviewers should focus on:
N/A
Screenshot
It's difficult to see the difference between before/after on these screen recordings, but is fairly tangible when interacting with the component "in real life".
before
Oct-19-2022.14-45-45.mp4
after
Oct-19-2022.14-45-59.mp4