Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icons for low & high voltage power poles #5682

Merged
merged 9 commits into from
Oct 21, 2022

Conversation

RexTheInnkeeper
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

added low and high voltage power pole icons

Reviewers should focus on:

make sure everything renders ok and correct files were changed

Screenshot

Poles 20px
Poles

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @RexTheInnkeeper! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these icons don't show up correctly in the docs preview build:

image

image

packages/icons/icons.json Outdated Show resolved Hide resolved
RexTheInnkeeper and others added 7 commits October 20, 2022 15:43
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Updated SVG format to be flattened figma svg exports to deal with
incorrect display in preview. Updated category of new icons in
anticipation of additional utility icons entering blueprint.
@adidahiya
Copy link
Contributor

@RexTheInnkeeper there are still some issues with the 20px high voltage icon:

image

resources/icons/20px/high-voltage-pole.svg Outdated Show resolved Hide resolved
resources/icons/20px/high-voltage-pole.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now:

image

I'm not sure if we'll keep a distinct category for "Utilities" icons like this, but it's fine for now. I'll probably reorganize some icons into a category for "map markers" or something like that.

@adidahiya adidahiya changed the title feat: new icon - power poles [icons] feat: new icons for low & high voltage power poles Oct 21, 2022
@adidahiya adidahiya merged commit 7628ae5 into palantir:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants