Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime2] feat(DateRangeInput2): support 'fill' prop #5715

Merged
merged 2 commits into from
Nov 4, 2022
Merged

[datetime2] feat(DateRangeInput2): support 'fill' prop #5715

merged 2 commits into from
Nov 4, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Nov 4, 2022 •
edited

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add support for fill={...} to <DateRangeInput2>, similar to DateInput2, Select2, etc.
  • Improve organization of DateInput2 & DateRangeInput2 example options and add some explanatory tooltips

Reviewers should focus on:

Behavior of new prop

Screenshot

Screen Shot 2022-11-04 at 4 33 38 PM

@blueprint-bot
Copy link

[datetime2] feat(DateRangeInput2): support 'fill' prop

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 8036a97 into develop Nov 4, 2022
@adidahiya adidahiya deleted the ad/daterangeinput2-fill-prop branch November 4, 2022 23:54
@adidahiya adidahiya mentioned this pull request Dec 1, 2022
Merged
@adidahiya adidahiya mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adidahiya @blueprint-bot