[datetime2] fix(DateInput2): display updated timezone immediately #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[datetime2] fix(DateInput2): display updated timezone immediatelyPreviews: documentation | landing | table | demo |
adidahiya
commented
Nov 6, 2022
Update packages/datetime2/test/components/dateInput2Tests.tsxPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5714
Checklist
Changes proposed in this pull request:
Fix
renderTargetdependency list so that the timezone displayed inside DateInput2 is updated immediately after changing it via the TimezoneSelect.The fact that we have to do this is a sign that React hooks are kind of lame.
Reviewers should focus on:
No regressions
Screenshot