Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(MultiStepDialog): allow multiple close buttons #5762

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

tinopetros
Copy link
Contributor

@tinopetros tinopetros commented Nov 19, 2022

Fixes #5758

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • isCloseButtonShown only affects the close button in the header
  • showCloseButtonInFooter independently affects the close button in the footer (and now allows the exciting possibility of having a third custom button e.g. to skip the multiple steps of the dialog.
  • Updated inline prop docs and omitted tests since there were none for close buttons previously

Reviewers should focus on:

  • The separation of isCloseButtonShown and showCloseButtonInFooter and that it works as expected depending on the set props.

Screenshot

Screen Shot 2022-11-19 at 3 40 15 PM

@tinopetros tinopetros marked this pull request as ready for review November 19, 2022 21:48
@adidahiya adidahiya changed the title Detangle isCloseButtonShown and showCloseButtonInFooter [core] feat(MultiStepDialog): allow multiple close buttons Nov 30, 2022
@adidahiya adidahiya merged commit e74a3f0 into develop Nov 30, 2022
@adidahiya adidahiya deleted the tp/msd/close-buttons branch November 30, 2022 17:26
@adidahiya
Copy link
Contributor

thanks @tinopetros!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multistep Dialog] Allow showing close buttons both in the header and footer for customizability
3 participants