refactor gulp build code #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 31, 2017 19:14
(replaced by globs)
use `projects.map()` to build array once and avoid duplicating strings
adidahiya
reviewed
Feb 1, 2017
gulp/index.js
Outdated
| @@ -8,27 +8,10 @@ const plugins = require("gulp-load-plugins")(); | |||
| const assign = require("lodash/assign"); | |||
added 2 commits
February 1, 2017 11:10
…or-gulp Conflicts: gulp/util/karma-config.js
giladgray
force-pushed
the
gg/refactor-gulp
branch
from
fe57c2d
to
622bb7e
Compare
refactor away from the taskNames map pattern.
|
I have an even sweeter refactor ready to go on top of this that hopefully resolves a lot of the ambient pain with this gulp build by making things much more explicit. But I'd like to open that as a separate review, so let's please get this one reviewed ASAP cuz it's still got some good relevant cleanup (like removing all those obsolete |
adidahiya
approved these changes
Feb 3, 2017
| @@ -111,5 +33,7 @@ module.exports = (gulp, plugins, blueprint) => { | |||
| }); | |||
| }); | |||
|
|
|||
| gulp.task("karma", (done) => rs(...blueprint.taskMapper("karma", "karma-"), done)); | |||
| // running in sequence so output is human-friendly | |||
| // (in parallel, all suites get interspersed and it's a mess) | |||
There was a problem hiding this comment.
for another PR: try running expensive parallel tasks in separate CircleCI containers
gulp/util/task.js
Outdated
| @@ -1,3 +1,6 @@ | |||
| /* | |||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
gulp/util/karma-config.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
| * Copyright 2017 Palantir Technologies, Inc. All rights reserved. | |||
added 3 commits
February 2, 2017 22:58
move blueprint to the beginning so it's like two key libraries, then a mess of auxiliary plugins all at once. also now it's alphabetized 👌
replaced by lerna in scripts/prepRelease.sh
|
pushed some last-minute tweaks that came up in my other feature work but make sense to get in here. review the last few commits individually for best results. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decided to give the gulp code a little polishing ✨
getTypescriptSources(replaced by globs)blueprint.dest(): unnecessary complexityblueprint.taskMapper(): useprojects.map()to build array once and avoid duplicating strings