Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Callout): link text color in primary intent callouts #5906

Merged
merged 2 commits into from
Jan 30, 2023
Merged

[core] fix(Callout): link text color in primary intent callouts #5906

merged 2 commits into from
Jan 30, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #5853

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add special styling for links inside primary intent callouts to make them appear clickable
  • Improve Callout docs example

Reviewers should focus on:

Visual design

Screenshot

2023-01-30 16 34 37

@adidahiya
Copy link
Contributor Author

fix typo

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 6987479 into develop Jan 30, 2023
@adidahiya adidahiya deleted the ad/callout-links branch January 30, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerinet CPerinet Awaiting requested review from CPerinet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links in callouts with primary intent look the same as other text
1 participant
@adidahiya