Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] fix(DateInput2): gracefully handle invalid timezones #5941

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

adidahiya
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Improve logic used to set the initial timezoneValue in the DateInput2 component. If the user specified an invalid defaultTimezone, or if the Intl.DateTimeFormat API fails for some reason, we now default to "Etc/UTC" instead of throwing an unhandled error.

@adidahiya
Copy link
Contributor Author

[datetime2] fix(DateInput2): gracefully handle invalid default timezones

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

remove unused import

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya changed the title [datetime2] fix(DateInput2): gracefully handle invalid default timezones [datetime2] fix(DateInput2): gracefully handle invalid timezones Feb 13, 2023
@adidahiya adidahiya merged commit b02e7b3 into develop Feb 13, 2023
@adidahiya adidahiya deleted the ad/fix-date-input2-invalid-tz branch February 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant