[select] fix: ItemRendererProps type regression #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
Feb 14, 2023
| export interface ItemRendererProps { | ||
| /** A ref that receives the native HTML element rendered by this item. */ | ||
| ref: Ref<any>; | ||
| export interface ItemRendererProps<T extends HTMLElement = HTMLLIElement, U extends HTMLElement = HTMLAnchorElement> { |
There was a problem hiding this comment.
we need two type params because MenuItems are weird and attach their ref to a different DOM element than the click handler. we should probably reconcile that at some point 🤷🏽
There was a problem hiding this comment.
actually, this turned out to be a bad approach. see #5946
[select] fix: ItemRendererProps type regressionBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix MenuItem references in testsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5943
Checklist
Changes proposed in this pull request:
refproperty optional inItemRendererPropsrefandhandleClickproperties inItemRendererPropsby using generic type paramsonClickandonFocusproperties inActionPropsby adding generic type paramsReviewers should focus on:
Tests are accurate & sufficient
Screenshot
N/A