Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop to allow opening a column header menu without selecting the column's cells #5956

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

OliverWales
Copy link
Contributor

Fixes #5929

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add a prop to determine whether clicking the column header menu should select the column's cells. Default true to preserve the current behaviour.

Screenshot

With prop set to false, opening the column header menu does not cause the column's cells to be selected:

image

adidahiya
adidahiya previously approved these changes Feb 20, 2023
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @OliverWales. CI did not build correctly on your branch, did you by chance enable the CircleCI project on your fork? You should disable that; as our CircleCI project will build forks automatically. It's ok, though, the code looks good, and I can test this out on develop after merging.

@adidahiya
Copy link
Contributor

Checked out the code locally, it builds & lints successfully 👍

@policy-bot policy-bot bot dismissed adidahiya’s stale review February 20, 2023 12:55

Dismissed because the approval was invalidated by another commit

@adidahiya adidahiya merged commit 4cbc9e1 into palantir:develop Feb 20, 2023
@OliverWales
Copy link
Contributor Author

Hi @adidahiya, I'm not aware of having touched anything CI-related on my fork, where do I check if this is the case and disable it?

@adidahiya
Copy link
Contributor

@OliverWales
Copy link
Contributor Author

Doesn't look like it 🤔

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking Table Column Header Menu Button Selects Column
2 participants