Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(TagInput): left padding when no icon or tags #6001

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #5998

Changes proposed in this pull request:

Fix left padding in TagInput ghost input when there is no left icon or tags. This got broken in #5966 when the DOM changed but some CSS was relying on a specific outdated DOM structure

Reviewers should focus on:

Fixes the linked bug

Screenshot

Before:

Screenshot 2023-03-06 at 2 52 28 PM

After:

Screenshot 2023-03-06 at 2 52 14 PM

Padding with tags is unchanged:

Screenshot 2023-03-06 at 2 52 19 PM

@adidahiya
Copy link
Contributor Author

[core] fix(TagInput): left padding when no icon or tags

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 7adf605 into develop Mar 6, 2023
@adidahiya adidahiya deleted the ad/fix-tag-input-padding branch March 6, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(TagInput) Placeholder misalignment due to missing padding-left
1 participant