feat: new icons - subscript, superscript #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: new icons - subscript, superscriptBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
|
Approved from design 🎉 |
michael-yx-wu
approved these changes
Apr 13, 2023
adidahiya
approved these changes
Apr 17, 2023
adidahiya
reviewed
Apr 17, 2023
| @@ -0,0 +1,3 @@ | |||
| <svg width="17" height="16" viewBox="0 0 17 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
@davidburns573 there's an issue with both 16px icons because of this 17px viewbox. they get clipped horizontally:
can you please fix this in a follow-up PR? I will likely hold release of this package until this is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Add subscript and superscript icons.
Reviewers should focus on:
Making sure everything renders okay and the right files were changed.
Screenshot