[core] feat(NumericInput, FileInput): add "small" modifier prop #6071
Conversation
|
Thanks for your interest in palantir/blueprint, @tmisirpash! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
There was a problem hiding this comment.
thanks @tmisirpash, can you please also add a demo for these new props to both fileInputExample.tsx and numericInputBasicExample.tsx?
adidahiya
changed the title
There was a problem hiding this comment.
looks good in the docs preview build! and thanks for adding CSS API support.
just left a few code style comments, otherwise this is good to go 
| @@ -26,6 +27,10 @@ $file-input-button-width: $pt-grid-size * 7 !default; | |||
| $file-input-button-width-large: $pt-grid-size * 8.5 !default; | |||
| $file-input-button-padding: ($pt-input-height - $pt-button-height-small) * 0.5 !default; | |||
| $file-input-button-padding-large: ($pt-input-height-large - $pt-button-height) * 0.5 !default; | |||
| $file-input-button-width-small: $pt-grid-size * 5.5 !default; | |||
|
|
|||
| $pt-input-height-small-difference: $pt-input-height-small - $pt-button-height-smaller; | |||
There was a problem hiding this comment.
nit: no need for this variable, just inline its value on the next line
| $pt-input-height-small-difference: $pt-input-height-small - $pt-button-height-smaller; |
There was a problem hiding this comment.
@adidahiya Done, but I had to disable the max-line-length lint rule for it to work
| $file-input-button-width-small: $pt-grid-size * 5.5 !default; | ||
|
|
||
| $pt-input-height-small-difference: $pt-input-height-small - $pt-button-height-smaller; | ||
| $file-input-button-padding-small: $pt-input-height-small-difference * 0.5 !default; |
There was a problem hiding this comment.
| $file-input-button-padding-small: $pt-input-height-small-difference * 0.5 !default; | |
| $file-input-button-padding-small: ($pt-input-height-small - $pt-button-height-smaller) * 0.5 !default; |
Fixes #5035
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot