Toast action can be a link #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 2, 2017 16:53
somewhat convenient that they're now different elements
adidahiya
approved these changes
Feb 3, 2017
| "ban": [true, ["Object", "assign", "use TS2.1 object spread { ...a, ...b }"]], | ||
| "ban": [true, | ||
| ["Object", "assign", "use TS2.1 object spread { ...a, ...b }"], | ||
| ["describe", "only"], |
| function wrap(toast: JSX.Element) { | ||
| const root = shallow(toast); | ||
| return { | ||
| action: root.find(AnchorButton), |
There was a problem hiding this comment.
I feel like we should be querying for components by class rather than tagname, hm?
There was a problem hiding this comment.
class isn't as easy as you'd hope. with shallow mounting you need the exact string, or a custom predicate. with full mounting, querying for ".pt-button" gives you the HTML element, not the React component, so you can't do React-y things to it. 😢
tgreenwatts
reviewed
Feb 3, 2017
| @@ -32,11 +32,13 @@ export class ToastExample extends BaseExample<IToasterProps> { | |||
|
|
|||
| private TOAST_BUILDERS: IToastDemo[] = [{ | |||
| action: { | |||
| href: "https://www.google.com/search?q=toast&source=lnms&tbm=isch", | |||
| target: "_blank", | |||
There was a problem hiding this comment.
Is this optional or will it always open in a new tab? Prefer to give users the option but not be opinionated
There was a problem hiding this comment.
optional. this is just an example usage.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
actionacceptsILinkProps(href and target), usesAnchorButtondescribe.onlyandit.onlyin TSLint for the same reason as console.log: useful in local development but problematic in real environments.