Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] deprecate IMenuContext in favor of MenuContext #6196

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

I realized after updating the no-deprecated-type-references rule to flag IMenuContext as invalid that we never actually exported MenuContext from the table package API.

This PR changes that, we now export MenuContext. The I-prefixed interface is now deprecated (it will be removed in v5.0).

@adidahiya
Copy link
Contributor Author

[table] fix: export MenuContext

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix lint, add IContextMenuRenderer to lint rule

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 3ffa41f into develop Jun 1, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/export-menu-context branch June 1, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant