Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Spinner)(a11y): add default aria-label prop #6232

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(Spinner)(a11y): add default aria-label prop #6232

merged 1 commit into from
Jul 28, 2023

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Jun 21, 2023 •
edited

Checklist

  • [N/A] Includes tests
  • [N/A] Update documentation

Changes proposed in this pull request:

Add default aria-label prop to the Spinner component to solve aria-progressbar-name failure. Can still be overridden with custom value if desired.

@adidahiya adidahiya merged commit c9c689e into palantir:develop Jul 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bvandercar-vt @adidahiya