Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Input): Mute input shadows #6343

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

CPerinet
Copy link
Contributor

Make input inner shadows a bit more muted to balance visual weight. When used in high density UIs, input stand-out as too noisy visually.

Before After
Screenshot 2023-08-29 at 11 39 17 Screenshot 2023-08-29 at 11 39 31
Screenshot 2023-08-29 at 11 39 21 Screenshot 2023-08-29 at 11 39 28

@CPerinet CPerinet changed the title Mute input shadows [core] fix(Input): Mute input shadows Aug 29, 2023
@adidahiya
Copy link
Contributor

adidahiya commented Aug 29, 2023

@CPerinet your branch is behind develop quite a bit. Can you merge origin/develop? That will fix the test infra build failure.

Have you tested this reduced shadow in low contrast environments like projectors screens?

Does this change affect our high-contrast styles at all?

border: 1px solid $pt-high-contrast-mode-border-color;

@adidahiya
Copy link
Contributor

To answer my own question: this does not have any effect on the high contrast stylesheet, I tested in Windows:

image

But this did reveal a separate (unrelated) issue where the "High Contrast White" borders are poorly styled:

image image

@adidahiya adidahiya merged commit 5217cd7 into palantir:develop Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants