Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-build-scripts] fix: remove unused 'ts-node' dep #6353

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

Looks like this is unused in this package. We've also migrated away from ts-node in eslint-plugin's testing infra, so we should be able to remove it completely from the repo.

@adidahiya
Copy link
Contributor Author

[node-build-scripts] chore: remove unused 'ts-node' dep

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

Note that ts-node was added here for use in the sass-compile script: https://github.com/palantir/blueprint/pull/5216/files#diff-8c508100032d0fe222dc9679ae03f037d137a2323c18decd3775ccea41dddf2eR15

But its usage was removed in #5904 and the dependency was never dropped. So it's safe to remove.

@adidahiya adidahiya merged commit cf75a5a into develop Aug 29, 2023
11 of 12 checks passed
@adidahiya adidahiya deleted the ad/remove-ts-node branch August 29, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant