Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(OverlayToaster): declare children prop explicitly #6369

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #6363

Changes proposed in this pull request:

Add children as an explicit prop in OverlayToasterProps to fix compatibility of the children API with @types/react v18.x

This is similar to the change we made for other components in #5266

@adidahiya adidahiya changed the title [core] fix(OverlayToaster): add explicit children prop [core] fix(OverlayToaster): declare children prop explicitly Sep 5, 2023
@adidahiya adidahiya enabled auto-merge (squash) September 5, 2023 17:06
@adidahiya
Copy link
Contributor Author

[core] fix(OverlayToaster): add explicit children prop

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit fde7156 into develop Sep 5, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/fix-overlay-toaster-props branch September 5, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlayToaster does not accept children as props with @types/react v18
1 participant