Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] feat: DateInput3 using react-day-picker v8 #6370

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

adidahiya
Copy link
Contributor

Related to #5652, #5699 - necessary to unblock React 18 support

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add new "v3" variant of DateInput which uses react-day-picker v8 via DatePicker3 (#5935)

Reviewers should focus on:

  • No regressions compared to DateInput
  • Test coverage
  • Documentation

Screenshot

image

@adidahiya
Copy link
Contributor Author

Fix tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya changed the title [datetime2] feat: DateInput3 [datetime2] feat: DateInput3 using react-day-picker v8 Sep 7, 2023
@adidahiya
Copy link
Contributor Author

adidahiya commented Sep 7, 2023

rightElement does not display correctly in docs example:

image

EDIT: this is actually an unrelated bug on develop, will fix separately: #6371

@adidahiya
Copy link
Contributor Author

minor docs fixes

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 5f40f68 into develop Sep 7, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/date-input3-rebased branch September 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant