[core] feat: new SegmentedControl component #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segmented controlBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
previously requested changes
Oct 10, 2023
packages/docs-app/src/examples/core-examples/audio/oscillator.ts
Outdated
Show resolved
Hide resolved
adidahiya
changed the title
add docs blurbBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
reviewed
Nov 8, 2023
packages/core/src/components/segmented-control/segmentedControl.tsx
Outdated
Show resolved
Hide resolved
Merge remote-tracking branch 'origin/develop' into cp/segmented-controlsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
|
Added support for small, regular, and large sizes (just like Buttons):
Added support for "fill" prop:
Added support for "inline" prop. You can see it used in the example options panel; without this prop, the "intent" control container would appear like
Also changed hover styling to take on the specified intent, I think this is slightly better, what do you think @CPerinet @jessperrin?
|
add fill, inline, small, large propsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3111
Changes proposed
SegmentedControlcomponent and docs exampleScreenshot