Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] feat: no-deprecated-popover2-components rule #6474

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Oct 19, 2023

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • (internal) feat: implement additional configuration syntax for "no-deprecated-*-components" rule implementations so that we can include target package names in deprecation messages, for example: "Usage of Popover2 is deprecated, migrate to Popover from '@blueprintjs/core' instead"
  • [eslint-plugin] feat: new lint rule no-deprecated-popover2-components
  • [eslint-plugin] break(no-deprecated-components): check usage of deprecated components from @blueprintjs/popover2@2.x

Reviewers should focus on:

  • New config syntax
  • Test cases
  • No regressions

Screenshot

N/A

@adidahiya
Copy link
Contributor Author

[eslint-plugin] feat: no-deprecated-popover2-components rule

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix README typo

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 1aee19f into develop Oct 19, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/no-deprecated-popover2-components branch October 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant